This. Don't think of it as an investment. Think of it as enjoyment and perhaps cost optimization.
At a high level, if you're going to Disney regularly AND wanting to stay on property in moderate to deluxe resorts, I think it makes a lot of sense. If Disney value or off property stays are more you're thinking then perhaps continue to rent on occasions is the way to go.
Couple of off ramps. You could look at owning for 10 years or so and consider selling your points. That helps with offsetting the long term expense of dues and recoup some of the initial cost. Also ask yourself if you're likely to do this while the kids are young (if you have kids) and then pull back or stop when they are older. For my wife and I, now that the kids are older, we love going by ourselves. Owning works for us long term.
Either way, good luck! Always a happy time to consider if this DVC choice fits or not.