Opinion here. If the scout wants the recognition and sends the letters, so be it. This thread brings to mind circling helicopters and the pilots/parents who want special treatment for precious snowflakes. I was raised that you do things to help others without looking for anything in return. Somehow, sending a request for recognition doesn't make the recognition appear to be heartfelt or genuine. Again, my opinion.
Definitely entitled to your opinion.

I just look at it differently. The boy didn't spend years in scouting earning Eagle rank (and it does take years) looking for anything. He wanted to earn it because it means something to be able to say that you've earned that rank (in the world of scouting at the very least).
Neither the OP, nor her son are looking for special treatment. These letters are something that have already been done, for years.
I don't think (and it's just my opinion) that it's snowflaky or helicoptery. And this is based on what we did for my grandparents with regard to the letter we got from the President for their anniversary. They never would've sent a request to the White House for the letter. We knew we could get one for them, so we did. We thought they be tickled by it and they were. It was just a little something extra that made them smile. I don't think my grandparents are special, snowflaky grandparents, but they are special to me personally and the rest of our family. And if there was something special that we could do for them, however small, we wanted to do it.
As this thread has proven, the world is full of people just waiting to tear you down, so if you can do a little something extra for the ones you love, why not?