I fully acknowledge that the golden years of being a Disney fan and a
DVC member are probably over. Those crazy promos and benefits were introduced at a time when Disney was still growing it's fan base. Now the opposite is true where Disney has WAY too many fans and they are trying to dis-incentivize some people from coming. Still, many people see plenty of value and benefits from becoming new members because Disney continues to innovate and bring new exciting entertainment. In your niece's case, I would definitely
advise her to not buy into DVC if she views it as a financial investment. If saving for college is her priority, I would take that money and put it into a 509 plan and pay rack rate, stay off-site, or rent DVC. I most certainly would not buy Riviera. Everyone's financial situation, priorities, and desires are obviously different. If she can't stomach the idea of forking over $30k to become a DVC member, she probably shouldn't be buying DVC IMO.