I can't believe only one person mentioned Raging Bull. It's widely considered by critics to be one of the 5 best films of all time.
In terms of popular interest, probably Bull Durham and Caddyshack, but I have a soft spot for Breaking Away. (Also Costner, very early on.)
A River Runs Through It also probably deserves a mention, though it's only partially about fishing.