Just going to add my thoughts as a mom of 3 who is finally done with fundraising.
Believe me, in all those years, we've done all of them, cookie dough, book fairs, carnivals, popcorn, Christmas wrap, and on and on.
My all time favorites were the "No Fundraiser Fundraiser". We mailed/sent letters to all the students parents and said, "Instead of making you hit up all your relatives to purchase stuff that they don't need, at high cost, with minimal return to the school, we're just going to ask everyone to donate a cash sum. That way you know all that money is going to the group you want it to." I worked so well, we did it for the next 2 years.
I also liked the Carl's Jr coupon books that we sold a few years for the high school band.