DVC is a way to pre-pay your vacation accommodations and can be a measure of cost savings if you typically vacation at Disney every year and if you usually stay in Deluxe resorts. It sounds like you might be an ideal DVC candidate. In terms of pros, outside of the actual program, there really are no big pros - you get what you get. You buy XXX number of points at a certain DVC resort, and receive those points every year in order to utilize for DVC resort accommodations. If you choose, you can trade those points out for Disney cruises or other vacations through RCI, but you will get the most "bang for your buck" by using your points at DVC resorts. If you find yourself in need of additional points, you also have the option to bank your points into the next year's allotment, as well as borrow points from the next year.
In terms of cons, being locked into
Disney vacations for the next 30-50 years may seem very daunting to some. Disney vacations are expensive, and DVC only covers your accommodations - - you still have to get there, pay for park tickets, meals, entertainment, etc. Also, you have to pay annual dues on your points, which equate to approximately what a Value stay would cost for a week. And, although you do have the ability to sell your contract, there is no guarantee that you won't lose money on the sale.
With all that said, though, DVC will either make sense for you or it won't. Continue to research so you know all your options, as well as the ins and outs of the program, and then buy (or not) accordingly. Good luck!
