We have old MagicBands and they work just fine to get into the parks, to open the resort door, and for charging to the room. They also work if you are having a Photopass photographer take your picture.
I have had trouble getting ride photos until I made the following changes to my cellphone settings.
1. make sure you are logged into the Disney Wi-Fi in the park
2. go to the WDW app and make sure the location setting is set to Always. Disney needs to track your every move.
3. keep the
MDE app open on your cellphone
Changes those settings has made the difference. Ever since I changed the settings to allow the app to allow track my location, it has worked for ride pictures.