I will say what I normally say....look at a DVC purchase in context of all of your financial priorities. Are you saving for retirement? Are you going to need a bigger home? How about kids school costs - private schools, college tuition? What is the opportunity cost of a DVC purchase - what financial things are you going to sacrifice to make it happen?
Look at DVC in terms of your life priorities as well. Owning DVC means that you are committing to a lot of Disney focused vacations - Disney World or Hilton Head or Vero or Aulani (maybe
Disneyland someday if DVC expands offerings, right now Disneyland isn't a realistic buy unless you buy VGC points). That means less vacation time to go to Cancun or London or Washington DC. It will mean less vacation time if your kids take up travel sports to get them to a soccer tournament near Chicago or a baseball tournament in Omaha. For many of us, this is a no brainer - most of our vacations are Disney focused. For others, DVC turns out to be not a great fit as our kids get other interests or our own travel bug means we'd rather go on safari in Africa rather than the safari ride in Animal Kingdom. (Personally, we bought DVC when our kids were toddlers, they are both in college now. Our daughter would much rather be in Europe than at Disney. Our son would much rather be on a beach than Disney. This change happened in middle school. Our son hasn't been to Disney in almost a decade (he says he'll go with us for our next trip, and he was with us at Hilton Head last Winter, but he stayed with Grandma after he was about twelve) For us, we had the resources for two vacations a year, and the points for an every other year vacation to Disney - so we were able to meet everyone's preferences)
Look at DVC in terms of your travel patterns. DVC works best for people who want to stay in a DVC resort at least every other year. It works best for people who will book their home resort at eleven months and then if something else is available seven months out, switch. It works best for people who can plan eight months to a year out, and somewhat paradoxically, works best for planners who can also be flexible (i.e. you want to switch at seven months and try BCV, but you are OK if you end up at BWV, VAKL or your home resort and you don't mind switching mid trip to get a few nights worth of Storm Along Bay, or you could move your vacation a week should what you really want open up). It works best for people who aren't looking for bargains like "free dining" and are fairly price insensitive - DVC MAY save you money, but with restrictive cancellation policies, the probability of losing points during your ownership (yea Covid), the "room is paid for, we might as well go" trip when you really should skip a vacation and financially retrench, and the psychological incentives to spend more on a trip when the room is "free" - most of us end up giving more dollars to the Mouse than if we were just paying cash for a room.
For people for whom DVC is a good fit, its a good fit. For people who are really trying to fit that square peg into a round hole, DVC is not flexible and is really an expensive luxury for a poor fit.