It all depends on what is important to you. We love the values and have stayed at the mods and deluxes as well. We have two kids 4 and 2.5. The 4 year old loves the All stars (well she doesn't know any different because she hasn't stayed anywhere else!!) But for younger kids, even a 7 yo, I think the values are perfect. There is no restaurant which is fine by us because we'd rather just eat and be done after a long day at the parks and our kids are not great in restaurants anyway (although we love the character meals and will eat at Epcot a few times since dh and I love Epcot!!)
The rooms are on the smaller side but it's never bothered us and we had two pack and plays in the room last year. But a friend of mine went last November with one pack and play and she thought the rooms were way too small, so it's all about what you expect. I think for the money you pay at the All Stars, you get a lot!!! The grounds are beautiful and the pools and playgrounds are fun. One of the biggest complaints about the All stars is the transportation to the parks but that isn't an issue for us since we always rent a car (lugging two strollers on and off the crowded buses is not fun!) Also, we have never had problems with noise and we always request ground floor rooms facing the pool closest to the food courts because of the convienence.
Next December we are staying at the WL because we are traveling with family who had previously picked that place and it took a lot of convincing to get my husband to stay anywhere else besides the All stars (and he is a "hotel snob", he travels a lot for business so he is very selective when he travels for business or prior to us having children) But since the All stars are so great for kids and convienent, I think we'll be staying there for a while!
If I were traveling without kids, it would be the Beach club for sure, I love being that close to Epcot!!
hope this helps! sorry about the spelling mistakes!!!