After many calculations and a reading all the thread responses to the one I started over the summer, I decided to buy VB. I was originally looking at HHI as a cheaper buy-in. I didn't ever consider VB and was against it. But the more I read and the more calculations I did, the more it made sense for me.
But you have to know your risks and be willing to take a bet on them. I bought 100 points at $33.50 per point (the lowest amount I saw passing; $30 pp were all being ROFRd by disney). I also got 100 banked points and 100 right after the purchase went through. I booked a 2013 trip, so I had 300 points to work with.
I calculated that the cost of the contract ($4120 including closing, etc) plus yearly dues vs renting ($11 pp from my source) would pay off in just under 5 years. So at 5 years, I could give away the contract and not have lost money.
Around 12+ years, the contract dues would start costing me more than if I bought on-site (average dues used). But as far as I'm concerned, even if I keep the contract long term, I'm still paying several dollars less per point than if I kept renting. And I can control my rez, check on availability, put in requests, and get whatever other benefits are offered.
If this rumored change happens, I will be grandfathered in (according to rumor) which means I got a very good deal at the right time. And if I want to sell, I can sell super cheap after 5 years and whatever money I get is profit at that point.
Some people pay more up front to save in the loooong term. I saved up front and might eventually pay more long term (if I keep the contract a long time). Money in my pocket now is better than money in my pocket later.
But that's just my theory. I may get screwed by the upcoming changes. If so, I'll rent out VB vacations and use the money to buy on-site points and transfer them into my account. Either way, I still have an advantage.
Just don't overpay for VB.