I will always stay off-site, in the Lak Buena Vista area, every time I go back. Maybe 'cause it feels like home after living there for a year?
But more for the following reasons:
1. Saving money for more fun, better food and better souvenires - most hotels are cheaper in the Lake Buena Vista area than inside the World. I've stayed at the CBR, the All Stars, the Beach Club, and The Poly and the Wilderness Lodge. For the little time I spend in my room, I just couldn't justify spending that much more money for the small amount of extra on-site perks. I would rather eat at every restaurant I want to, order what ever I want and be able to bring my family nice gifts than spend the crazy amount of $ on the room I'll sleep in and nothing else.
2. Services - I like to do the other attractions when ever I go back to Orlando. I choose a hotel that has free shuttles to all the other parks (SeaWorld & Universal & some malls). I might rent a car for a bit of my trip, but not the whole...so having the convenience of free shuttles to the other parks is a must. They also provide shuttles to and from all 4 major theme parks. When you have Disney transp. to rely on for anything else you want to do, I see no added bonus in being on-site for the shuttle services. If ever I miss the last bus back to the hotel, all I have to do is get bak to DTD on Disney transp. and from there it's either a 20 min walk or a $5 cab ride. Just my preference...
3. A Disney Break - sometimes, and maybe I'm in the minority here on the Dis, I need that break or I get Disney overload. The same trained voices giving you spiels over and over and over again. Just a break at a non-disney pool or maybe a shopping centre across the street that's within walking distance. I know a lot of people differ and want to be surrounded by the Magic 24/7. But not this former CM. Been there, done that.
I think the only hotel on property I wouldn't mind trying is the AKL. Of course the other hotels were great...but not worth giving up the things I listed above.