Disney not only makes money upfront by selling the DVC real estate ownership "slices" for far more that it costs to build the units, Disney continues to make money by collecting a management fee of roughly 2% of the annual fees. That's guaranteed net profit, in good times and bad. (This 2% doesn't go to admin costs; the admin costs are considered expenses in the budget, just like housekeeping and reserve funds.) In addition, DVC brings back guests year after year -- whether there are new attractions or not -- to spend money at Disney parks, restaurants and shops.
By the way, there's nothing wrong with having a management fee. That's how property management companies make money.
When it comes to the regular Disney resort hotels -- value, moderate and deluxe -- it's just good business to consider whether it makes more sense to own the assets, or just to operate them, or to operate them with a brand affiliation, or to let a lodging company operate them (either with a Disney brand or a chain affiliation). What's the best way to make money for shareholders? Wouldn't it make sense to sell the assets to free up capital, use that capital to reduce debt, and then lease back the hotels and operate them with no visible change to the guests?
Marriott International used to own hotels. Their return on investment stunk. Marriott set up separate companies to own the assets, to operate the hotels, and to manage the brand. This has worked out well for Marriott International shareholders.
There is nothing wrong with Disney making sure that their shareholders get the best return on their investments. But if Disney frees up capital from hotels and then uses the money for their aircraft leasing business or to make bad movies or to subsidize follies in broadcasting, well, let's just say that would not be in the interest of shareholders.