You will always get enthusiastic YESes around here, including from me, but I'll caveat mine. Do you and your kids like Halloween? I know some people who just aren't Halloween people, and they would probably hate MNSSHP. If you love the Haunted Mansion and Nightmare Before Christmas (and stuff like that) you're practically guaranteed to have a great time. It can be rather crowded (but ride lines are SHORT!), especially at sold-out events. Dressing up is fun and seeing all the costumes is amazing!
If you like Halloween, don't hesitate, especially because more dates are selling out than ever before. Don't wait until you get there. I'm not sure when tickets go on sale, but it will be several months out.