I am going through the selection process in my head right now.
My criteria are:
1) Novel location - with all the variety at WDW I like trying a different resort every time. I don't go all that often so I still have a lot of places to try.
2) Space - DH prefers having a separate bed away from the kids, so that limits us usually to
DVC, wilderness cabins or family suites. I am going to try to talk him into a Poly villa this year though because I think the location has too many benefits to pass up. We usually rent DVC points.
3) Cost - Since we only go every 3-4 years, cost is less of a factor, but it is still surely a factor. It prices us out of Grand floridian or Bay lake Villas.
4) Amenities/dining/transportation options - we stayed at the AoA family suites last time, and while we did not care for the cartoony look of the resort, we loved the fact that the central location meant short bus rides everywhere, plus we were close to the main hall so we had a very short walk to the food court and bus stops. It really makes the daily flow so much better. The mornings were more leisurely and I could grab a quick snack anytime. I will definitely put more thought into that aspect of planning.
Our choices for our next trip are:
1) Poly villa - provided I can talk DH into not having a separate room. Fantastic location, pool, dining options etc...
2) Old Key West - lots of space, inexpensive, but a pain to get anywhere unless we rent a car, which I really dislike doing.
3) Animal Kingdom lodge - the most expensive of the three options, especially with a savannah view. While there are a lot of dining options, I think, from our experience at Boma years ago, it isn't our families favorite type of cuisine. It would be cool to see the animals though.