If you don't really care about the pins, then by all means, put them in your checked baggage. I always carry mine in my carryon bag...haven't had an issue yet.
Always carryon. They are way too valuable to be checked. Was stopped once in MCO, they hand searched my bag and let me through no issues. Last trip at MCO the TSA screener asked who had the Disney pin collection and laughed
Really??? Have you not read the various posts here from guests who have lost their pin collections because they put them in their checked baggage??? I always tell people to not put anything they can not easily replace in their checked bags. I have had some pretty, what I thought to be, worthless items stolen from my checked bags. I can't imagine putting something in there that I would hate to lose.