Yes, every vacation spot is a 'destination spot'...but if I rent a cottage on Cape Cod, I venture away from that cottage. I spend my money in the next town. If I head to NYC, I spend my money in a variety of places.
BUT...with WDW??? The vast majority of guests do not venture offsite. They stay right there, and almost 100% of their vacation dollars go to Disney. That's my point.
So...you have a choice here. Disney is NOT telling you that you have to come to WDW, you have to stay onsite, you have to do all your eating onsite, you have to keep all your money onsite. They DO, however, make it very easy and convenient to do that. There are many ways to 'do' WDW less expensively. You can stay offsite in much less expensive hotels/resorts. You can rent a car and eat offsite as well. Or....shop and get your own groceries. You can head to other sights vs spending all your time at WDW.
No one is demanding that you go to WDW and stay there...at a deluxe resort, with 10 day non-expiring park hoppers, using the
ddp. There are ways to do it much less expensively.
All that being said.....yes, it costs a boatload of money to go to WDW. Always has. And yes, things have changed at WDW.....food options have diminished, food cost has gone through the roof, restrooms aren't quite as tidy as in the past (although I've seen just one or two instances of that personally), CM 'magic' seems to be going by the wayside. But again..no one is forcing anyone to go to WDW.
There are plenty of people willing to have that experience..whether it's the same as it was 10 years ago or not. And as long as that's the case, Disney will continue to keep being so expensive.