OK, I am a financial planner, I own 150 pts at SSR and I like Dave Ramsey.
A
DVC purchase is a bad idea if you have to finance it. It is not an investment and should not be viewed as such. If you are not contributing to an IRA/401 K account, you should not be buying DVC. If you owe money on credit cards etc, you should not be buying into DVC. If you have to take a second job to "afford" DVC you should not be buying into it.
That said, if you are well on your way to funding a secure retirement, have no debt other than a mortgage, then DVC is a nice purchase if you like vacationing at nice resorts at Disney.
I have "moderate" net worth clients ($500,000 in investment assets) that I have encouraged to buy into DVC. Why? Many of them never take a vacation and the DVC purchase FORCES them to take an annual vacation. If you can not afford a second home, it is the next best thing. Besides, the $13,000 DVC purchase will have no effect on the eventual retirement of someone with $500,000 of investment assets already.
I do not blame Dave for his "blanket comment" because his audience is largely made up of individuals that have screwed up bad. He probably does not want anyone to go and buy because "Dave said it was OK."