On to the OP....I will say that some of the magic has came and went through my visits here. Our first visit was during 9/11, so I can't compare to prior 9/11. My girls, 8 and 11 still get excited and scream as we pass the gates to WDW, but there are things that don't excite them or me the same. We used to think Chef Mickeys was the best, including the food. We finally gave up on it about 2 years ago as nearly inedible. The castle food has priced itself out for me. We went 3 times and thought it terribly crowded and overpriced and that was before the last few price increase that included the portrait.
We are slowly discovering new things that suit us just as well. This time my DH played golf 2x and he had never played here before. The girls and I went to the spa at SSR and love it. I try to schedule at least one new thing per trip. We don't actually stay in the parks all the time. We have been here 8 nights and have visited MK 2 mornings and 1 evening, HS 1 morning, Epcot 1 morning and 1 evening and AK 1 morning and will go back to Epcot tomorrow morning. We love the resorts and like the DVCs and room to spread out and relax on vacation.
Is some of the magic gone? Yes, but as my children age I imagine that would have happened whether or not the economy took a hit or not. I would never invest in
DVC just based on 1 park or 1 or 2 attractions because things come and go. I do expect to find ALL the magic again when I am blessed with grandchildren one day. I also would love to take some of my girls friend who have never been to see the magic because I do believe it is still there, we just look past it sometimes.