I don't think it has gone downhill. At least, not since I started using it in 2010. However, I do think it has always been hit or miss. It depends on the skill of the photographer, the lighting and how busy they are. We've had some truly horrible shots and I always carry my own camera, but we've also had enough true gems to keep me coming back to pre-order the CD every trip. I'm a scrapbooker so pictures are my souvenir.
Some tips:
(1) hit the photographers in obscure locations or when they're not busy. Having time to compose good shots make all the difference. I love the ones in World Showcase and there's always one on the bridge to Tomorrowland at MK. It's a beautiful shot of the castle from the side, and it's much less busy than the ones in front of the castle.
(2) If you don't have PP+ tell the character photographers you pre-ordered the CD. Usually this spurs them to start snapping the "interaction" shots and not just the posed. I have great pics from
MNSSHP of my son dressed as McQueen with Daisy "driving" him around. Priceless!
(3) take the opportunity to get different family groupings. As the family photographer, I love being in the shots. My family is also trained to stop every time they see a photographer. And we mix it up a lot. I have beautiful pics of DSis and me. Pics of just DH and I. And several lovely shots of my parents on the bridge between France and UK. Again, priceless.
(4) hit the resorts at holiday time. Again, quality depends on how busy they are. Our GF pics were rushed. But we caught the AKL photographer at a slow time and he basically did a full family photo shoot with all the different family groupings. These are honestly the best pictures we've ever had taken - anywhere. I'll try to post some later.
(5) Ask for magic shots. There are new ones coming out but we have nearly all the old ones. My son loves them and we ask every photographer we see. Again, time and skill are a factor. They don't always turn out but we have some great ones.
On that note - I read that they're changing the magic shots to make them less location-based. That every photographer will have access to a bunch. And they're adding new ones. Can anyone confirm this? Have the changes rolled out?
For the first time, this trip I'm looking at not ordering the CD. We have 3 days in Nov. and I know I could make it worthwhile, but it's just not in the budget. If there are new magic shots though, I'm going to be sorely tempted.