We stayed at the Buena Vista Palace about a month ago, in an Epcot fireworks view room. We had previously stayed in the same area during their construction a few years ago, and it was okay, so gave it another shot. I'm not sure I would stay again, for the price/resort fee. Firstly, it's a convention hotel. Our first stay was annoying because of drunk conventioneers on their balcony - hotel staff could not get them to answer the door or the phone, despite repeated attempts (not the hotel's fault though). This trip was much quieter, so it totally depends on the neighbors, as anywhere.
Our biggest issue was parking. There is no designated area to park for check in, and the valet's had no idea what was going on. Actual parking is way down a hill, behind the convention hall, in an unsecured, unlit lot. It's quite a hike to your car.
Other than that, we had to wait for our room to be cleaned at 4:00, which wouldn't have been a big deal if the bar was open. The resort fee covered 1 drink per person, per day, which we were unable to use because the bar wasn't open yet. Not a big deal.
The room was fine, bathroom counter space is almost non existent. Bed was comfy, and the room was huge. We could see all of the fireworks shows as well.
The walk to DS isn't bad at all. Maybe 10 minutes, and it's fairly well lit the whole way.
I would stay here again if I could get the resort fee waived, and there wasn't anything on property.