It depends on your financial situation. If you can spend the money and never miss it, go for it. If you would normally pay to stay at a deluxe resort, ditto.
For our family, we just couldn't justify DVC, even though we are Disney nuts. We were there six weeks last year, but all were offsite in some of the non-DVC timeshares. The Orlando timeshares are some of the nicest anywhere since there are so many and the competition to be the best is so great.
We bought timeshares about 10 years ago when our kids were roughly 10, 8, and 1. I wouldn't travel any other way now (on purpose) because the extra space is so wonderful compared to hotels. The kids are 19, 17, 11, and 6. The oldest don't always go anymore. Having two or three bedrooms, full kitchen, washer/dryer, three or four TVs, and a nice patio or balcony to relax on is wonderful for us.
Just remember that the fairly reasonable purchase price for DVC is just the beginning. The annual maintenance fees scared us off.
You'll find people who feel strongly both ways on this issue. I would buy DVC if I had more money, but I don't, so I am very happy with the choice we have made.
Sheila