But the flip of that argument is that you should get to use two FPs so the smaller child can use one. Whether it was a favorite or not, you used one to ride with the smaller kid. Then you used RS to get a second FP for the ride you wanted to ride. So you -- and two others -- get two FPs with the actual entitlement of one.
Also, you say it doesn't take anything away from anyone, but it does slow down the FP line, doesn't it? If everyone in your party had FPs, then the later slowdown would have been compensated by the earlier speed up when you didn't use them. But as it is, you're talking about adding two or three FPs to a line. Maybe not a big deal to you because you benefit from it. Maybe not a big deal to anyone. But it's a misnomer to suggest that there is no effect, when there actually is one, and if RS is used this way a lot, that effect cumulatively increases.
I disagree.
I'll use my family as an example. Take a look at the below scenario:
Myself, and two oldest kids get FP's for Space Mountain, and DW and youngest get FP's for Buzz. We get a Rider Swap for Space so my wife can ride with the two oldest on Space again.
The rider swap is good for 3 people. If my wife had a FP for space, she would not even be able to use it (unless she wanted to go by herself).
So 3 people entered the FP line with FP's. Then 3 people entered the FP line again, using Rider Swap.
If wife had the FP for Space, then 3 people would still have entered the FP line again, 1 using a FP, 2 using the rider swap. Her using the FP would be wasted, as the rider swap already gets her in. It's a net 0 change. There is no effect.
If she decided to ride by herself just to use the FP, then there's another person entering the FP line. Instead of her doing that, DW and youngest get FP for Buzz, both use their FP. No cheating or rule breaking there.
Again, its a net 0 change. But instead of riding Space by herself using the FP, she uses the FP for Buzz.......
No other side to that....
ETA: To simplify, 5 people were eligible to book FP's and use them, 5 people booked FP's and used them. 0 net effect.....