York is just like any town, it has some good parts and not so good. But for the most part it is safe. The 2 new hotels are Homewood Suites and Windgate by Wyndham. The Red Roof Inn right on Rt.30 was just redone a few years ago, and they usually have cheaper rooms. If you are going straight from Gettysburg to Lancaster you will take Rt. 30. There are a lot of hotels on Rt. 30. It is not a very long trip between the two. I guess I am wondering why you need a place to stay between them.