No question that
DVC is a great deal more expensive for Canadians now than it was a few years ago. But one thing to keep in mind is that if you're going to Disney, your costs are going to be in USD anyway. Yes, DVC costs more in CAD terms, but so does whatever other accommodation you'd be paying for. So if it made sense for your family to own DVC 6-12 months ago, and you don't expect your vacation patterns to change due to the exchange rate, then owning DVC probably still makes sense. Or at least, the difference in exchange rate itself is likely not a big factor, unless it means that the upfront purchase price is now more than you can afford, or unless you expect a big recovery in the CAD in the foreseeable future.
Trust me, I know just how you feel. I first started looking at DVC in 2012, when the exchange rate was par or better, and DVC resale prices were at or near their bottom. I couldn't justify the cost then, based on how we expected to use it. Largely I was considering the ongoing cost of maintenance fees, which hasn't really changed. I went and bought a different time share instead (which we've been very happy with), but I have continued to look at DVC off and on over the past few years. Over that time my expectations of how we would use DVC has evolved, and recently I finally decided to go ahead with a small contract. It's painful to think of how much cheaper it would have been if I'd just gone ahead with it three years ago, but my crystal ball must have been broken then. I've found a model that should work for our family based on prices and expected usage
now, and while I'm very well aware that it's not the best investment decision I've ever made, I also don't think I'll regret it.