Things change significantly over time.
When I bought
DVC 25 years ago, it was a little more than 50% of my vacation budget.
I tend not to want to bunch up savings vehicles or retirement savings accounts that I 'could' have dropped my DVC money into with these rationalizations, because I'm going on vacation no matter what. I also saved for retirement no matter what. My trips are DVC mostly in winter months, more local beach vacations summer months, NYC type trips for art/theater etc., and other trips for various purposes.
The cost of my dues is less than a third of all these adventures. But back when I was younger, the cost of DVC was a higher percentage. A few things happened: one being that the upfront cost of the contracts were wiped out as I purchased them. A second was my income increased significantly as time moved forward. I also watch for every little savings because that's who I am, such as collecting discounted gift cards to pay dues. I see various versions of this on these boards.
DVC served a purpose big time while I had school aged children. I was divorced and DVC felt so safe and predictable during those years. The kids were not bored going to Disney until they hit late teens/or college where the schedules didn't mesh as well. That also forced me into following the school calendar so I spent lots of trips doing Xmas and Spring break trips. I don't have to do that too much anymore but occasionally it happens.
The one year I couldn't go I was able to rent easily using this site's rental board.
If you already have a dedicated vacation budget and DVC fits, it works. If you are pulling money from other needs (and vacation is a need for me) then maybe you should really consider if this is right for you. There is no one answer that works for all.
I would caution not to over buy. I think a lot of people on here probably do that. Save some time and money for other adventures.
Some people give themselves an extra job managing this. I really don't want the job, as I'm now retired and free to do what I want, which sometimes is just snoozing while reading on here.
Enjoy your personal choices. Don't let them become burdens. Life's too short.