Well, he wouldn't be my husband if he spent even a penny on tobacco as that is a deal breaker. I didn't marry a smoker, so he better never start. Any money spent on tobacco is a tax on the incredibly stupid, IMO. I find it odd that people spend that much money to kill themselves and others around them. Sorry if I hurt any feelings, but that's how I feel.
If he spent $5 a week on sodas at the convenience store, I might talk to him about it. We can buy a 6-pack, 12-pack, or 2-liter for a lot less money. If we are away from home, that's understandable buying a drink, but not in the everyday world in which we live. He has soda at work and at home, so we don't need to go to convenience stores often.
A sneaker habit like you describe seems like a behavioral disorder to me, so that's another matter.
I don't get upset with him for spending money on the lottery, but I do think it's a waste of money. I do ask that he keep all his losing tickets until the end of the year, that way, if he does win, we can offset the taxes on the winnings by the losing tickets. At the end of the year, we throw them away because he's never won big.