I liked the butterbeer softserve in Diagon Alley. It was a bit aggravating that they didn't have it at Hogsmead as well. I also had the frozen butterbeer. It was okay for an Icee but when its 3 dollars more than a normal Icee, I can do without it.
We never ended up getting the big pink doughnut but my son did get the doughnut sundae. He wasn't super crazy about it. I also got a flaming Moe. The cup is nice but 9 dollars for orange soda is a bit much. IMHO all and all the snacks are better at Universal than Disney.