If I'm going for a full week, I don't think it's worth it to do an official hotel and go for a nice offsite condo, similar to the ones you are considering. We've never found the lines at SeaWorld to be too bad.
On mini trips though, say four nights/three days like my next trip with a smaller number of people, just two of us where renting a condo would be overkill, plus the best condo deals are typically for a full week, I do often pick a SeaWorld partner place if I am going to do a day at SeaWorld, something we almost always do, since we really like that park.
For our trip next time, just me and my son, I'm getting a double queen studio at the Marriott Residence Inn SeaWorld -- includes breakfast, quick queue, has a kitchen -- always nice. I like the pool and hot tub too. It will be perfect for us for the mini trip. On a longer stay or if we have a larger group, the additional space, balcony, and amenities of a condo win out.
If you can get a good deal at the Hilton Grand Vacation Club SeaWorld, a very nice timeshare, that would be a great offsite condo and quick queue would be included too. Usually as many Hilton members trade for that we have done other offsite condos instead, just because of the deal we could get. We have stayed here in the past though and think it's lovely.
I think you will be absolutely fine with whatever offsite place you pick. With SeaWorld being primarily animal exhibit and show based, crowds aren't the issue that they are at Disney. Also for the coasters and popular water ride, lines aren't all that bad and going early morning and late in the day are good options for shorter lines.