Im a huge fan of it. . . Especially if:
-you have a long trip 6+ days
- you have a big group (family, friends together)
- you love to scrapbook or otherwise collect trip photos
- you'll meet at least a few characters
- you plan to do Jedi training or participate in a Enchanted tales with Belle (they take lots of pictures at both of these)
- you'll make the time to stop at photographers for a pic and sometimes ask for magic shots
- you'll ride many of the rides with photos
My group was all of the above, so it was fabulous. The more items that don't apply to you, the less value you may see in it. I really love the ride photos - something I've never thought of buying otherwise (usually just glanced at them on my way out of a ride) but it's a shot you can't duplicate with your own camera and makes such a fun addition to other posed shots.
ETA: Haha! Posting at the same time as the PP, I see we had the same general list idea! Put them together and there you have it! The definitive opinion