Those who said you are "punished" if you save for college are correct. And, while it's difficult to make predictions, especially about the future, I will predict that this "punishment" will only get worse as our state budgets get squeezed over the next 15 years.
With the state of our state's budgets throughout the country I'd imagine that "aid" will be harder to come by. And if you have money set aside for college I wouldn't expect to get much aid at all. The government will want every last penny from you before they give you any aid. Look at it this way: who is going to get the aid, someone with no money saved or someone with $200,000 saved?
In my opinion your best bet is to be as poor as possible (on the FAFSA) when your kids go to college so you to can get on the government gravy train.
That is our plan. We are saving for college via Roth IRAs. Home Equity, IRAs, 401ks and Life Insurance cash value don't "count" as assets available for college on the FAFSA. If you have $10 million in an IRA or 0 in an IRA the government looks at you the same. Because of our retirement crisis I expect this rule to remain the same in the future.
So somebody with $500,000 saved in 529s will have that held against them and get reduced aid. Somebody with $500,000 saved in Roth IRAs won't have that held against them. You can put $11,000 for a couple (5500 per person) into Roth IRAs each year. If you have more than $11,000 available to save then go ahead with 529s.
Our plan is to look as poor as possible and take out every subsidized loan and get every scholarship available during the college years. Then as soon as both kids are finished we'll cash out our Roth contributions (the earnings will stay in the Roth) and sell our house, and use that money to pay off the loans. We'll use 401ks for our retirement. In all of my research on this topic this is the strategy that maximizes the payoff for the parents.
Saving for college is a sucker's game. The government will be there to "help" those who couldn't/didn't save money for college. If you saved and were responsible you won't get any "help". I plan on using that reality to my benefit.