If you're staying at the 7 "Official WDW Hotels" at Disney springs that get 60 day FP and EMH, there are pros and cons.
Pros:
Similar perks to onsite resort guests
Can use loyalty points to book (saving money)
Can take advantage of hotel chain discounts (which may be better/more frequent than WDW resort discounts) without needing an AP
Transportation to the parks is available
Can still input your reservation into
MDE for trip management with tickets/FP/ADRs
Cons:
Transportation is not as frequent as WDW resort buses
No bus to the parks from Disney springs
Less theming/out of the "bubble"
No airport transportation/Magic Express, so you either need to uber/lyft/hire car or rent a car to get there (and pay parking fees)
Resort fees
Can't purchase "packages" and pay off your WDW park tickets over time.
it's always worth pricing out several options - there may be times that an onsite resort is a better deal (or provides you with more personal value). We did our first offsite stay last year, and did it again this year at the Wyndham LBV (which is a WDW official hotel). I got a great deal on the room, and we didn't feel like we were missing any magic. YMMV.