I'm cool with off site. I last stayed on site at CBR in 2019 and it was nice, but what the rooms cost these days is unreal, and we are a family of 5 so we cannot stay at certain properties. One day I would like to stay at a place like the Poly, but can't come to terms with the spending on top of 5 park tickets, plus food, airfare.... gets crazy fast.
I really like condo type places with separate bedrooms, in-room laundry and kitchen so I can cook some meals, pack less and go home with clean laundry, and I much prefer driving over taking a Disney bus. So off site doesn't bother me at all. They are both nice but I would prefer to be able to go to WDW once a year or two and stay offsite than not be able to affford to go at all because I can't pay so much for a room.
Different strokes for different folks.