I think it depends what your priorities are and your budget. If I stayed off-site (even at DTD) I'd want a rental car. I wouldn't want to rely on a shuttle. So that adds to your wedding budget. Did you have to pay for your plane tix? $$ Are you in the wedding party? $$$ Gift.$$$ Add all the moeny you're already spending on the wedding and recreation to a rental car. Can you swing it? Plus are you going to be in the parks a lot? How long are you staying? I wouldn't give up the access to the EMH. I know a lot of people hate Values. If I could afford to stay at Moderates or higher every trip I definitely would but sometimes we can't. And if Pop Century or All-Star Movies is all I can afford than we are fine with it. I've never stayed in a deluxe. My bank likes to get their mtge. payment every month so that would be a treat for us. I am hoping to get a decent AP rate at WL for August, though. I've stayed at every moderate except for RIverside and I have to say for us, it was no big deal. We've stayed at CBR many times but last summer were not happy. It's annoying to have to take a bus to eat!! We weren't that far but it was a pretty long walk after all the walking we'd already done during the day. And the food court is much better, IMHO, than at CBR. Didn't like CSR at all and many people love it. Not Disney enough for me & didn't care for the food court set-up. So I would say unless you're a Deluxe all the way family, you'll be fine. You're really not in the room that much. I guess you'll already have a car though, now that I think about it because how will you get to the wedding , LOL! Is the whole wedding party staying at the All- Star? The only All-Star I would NEVER stay at-ever- is Sports. we walked over there fromMusic when we stayed there back when they opened and found it much more loud and busy. We're not into Sports at all so that could be it. I probably wouldn't stay at Music either just because we like Movies and Pop so much better.
Good luck & don't worry it's Disney and it's a wedding. Happy & Happy!!
Elise