Well, it looks like you tend to vacation at WDW at least once a year. If you expect that you'll be continuing to do that for the forseeable future, you've made an excellent choice for sure.
Granny mentions the posts that talk about their great trips recently. Overall, a trip to WDW is still a fantastic experience. When you read the boards you sometimes start to worry about things that aren't really as big a deal as they seem here.
Early entry and E-nights have been curtailed. They may be back in the future. Personally, I've never made much use of them and have still had wonderful trips to WDW. When you know you'll be going back to WDW it's not as necessary to cram everything into each trip.
Attractions closed? Well, they do change attractions every once in awhile. At the time, some people see it as a great tragedy (Mr. Toad's Wild Ride) but it's soon forgotten when something new comes along to replace the old attraction.
I'm not sure about the airfare question. Right now there are unbelievably inexpensive air fares. But, that's a result of market changes. Right now no one can predict what the future holds and how the airline industry will end up. That's an unknown but I think it will work itself out in the long run.
I wouldn't risk other family expenses but if you can swing it, like you would swing buying a new car or planning a deluxe vacation, then I think you'll be happy with your decision.
