I always stay onsite - for
all the reason's DizMe stated above. I won't repeat all of it, because she pretty much summed it up really well!

The last two trips, I have stayed at PPH, then GCH before that a couple of times, and I used to stay at DLH ALL the time in the '80s and '90s, before there was a PPH or GCH to stay in!! I like being immersed in the Disney feeling from beginning to end, and everywhere in between in my DLR trips. I also like the adorable bath products with the Mickey ears on the bottles at the DLH and PPH! (GCH has H20 bath products.) Technically, I
should be staying at the cheapest place I can find, based on my current money situation. If I went to DLR more often - like, let's say 4 or 5 times a year instead of one or two - I would probably stay at HoJo's once or twice, or one of the other off-site hotels. But if I am going to be at DLR one or two times in a year, or once every other year, I want to go full, all-out Disney in every aspect! I do try to capitalize on whatever discounts are available at the time, whether it be special PIN codes or AP rates!

That definitely helps a lot during the holidays!
Oh, and I have used the service of sending my purchases back to the hotel on many occasions and it is SO handy. And it is free. There is no charge for it. Because I am a klutz and tend to drop things (or break them), I feel much better knowing that my purchases are safe and I don't have to worry about dragging them around the park with me and damaging them. Also, I don't want to have to get an expensive locker if I only have one bag of purchases. It is just nice to not have to lug something else around or make a special trip back to the hotel just to drop off souvenirs, etc. You simply make your purchase in any DL or DCA shop, fill out a form letting them know which hotel you are in and what room number, and voila! Your packages are available at 7:00 a.m. the next morning at your hotel's Bell Services desk! So convenient!