My best advice to you is to look over all the information and make a decision that is best for YOUR situation. People like to weigh in and give a recommendation to you based on what is best for them. Even the highest rated hotels and resorts in the world will get 1* review because the weather was bad. It is the generalities that are important.
DVC is a luxury purchase. Some people see the world in dollars and cents. Everyone is different. Many things in life are terrible purchases. Ex)
-Cars - we can walk, talk the bus, cab everywhere cheaper than buying a car
-Homes - we don't need 2, 3 4, bedroom houses. Big families are perfectly capable of living in small 1 bedroom apartments. Millions of people all over the world do this every day
-Cell phones - the world was fine without them but we seem to have created our own need for them. In reality, no on 'NEEDS' a cell phone.
OR we can use the money we make to enjoy as we see fit. What works for me will not work for everyone and vice versa. We buy luxary items for convenience and to make or life a little easier and a little more enjoyable. DVC is not for everyone. But to suggest its good for no one is ridiculous.
Now having said that I'll give you my families experience with DVC. Our situation was different and won't apply to everyone but maybe some of our experience will help you in your decision.
We purchased on our honeymoon on a cruise back in 2011. We had been to Disney before together and loved it (I proposed in WDW). We knew we would be going back and would bring our future kids. We had heard of DVC but really new nothing about it. We saw an ad on our cruise for a presentation and figured we would take a look. We went and loved the idea. Got pricing info. Went back to our room and discussed and decided we would do it. We had done no prior research before (a big no no to some people). Since we were on the cruise we decided to finance as communication with home was non existent. (Financing - another big no no for some people). We closed the deal and when we returned home we moved the Disney loan to our bank at a much lower interest rate and paid it off in a couple years. Now one thing with our purchase, we are Canadian, our dollar at the time was above the american dollar which made a huge difference. However, financing had saved us Tens of Thousands of dollars. Had we waited and saved to pay cash it would have been more expensive. Direct prices went up, Canadian Dollar went down.
We were owners for a little over 8 years. Took many wonderful trips and have not regretted it for a minute. We took 3 trips to Aulani for a total of 34 days with one trip in a 2 bedroom with my parents. They had never been and likely never would have gone without our DVC room.
Fast forward to earlier this year. We were looking at our finances and what we wanted to do. Our kids are 7 and 5 and their activities have begun to consume a lot of our time (and money). Something we could not have predicted. Between school and activities, planning vacations has been a little bit harder. Plus, coming from Western Canada, we couldn't go to WDW for a weekend getaway. A week to 10 days minimum to make the travel worth it. That gets expensive in other areas. We want to see other places now that the kids are older and more appreciative of other things. We still want to do Disney but now we are looking at every 4-5 years instead of every 2-3. Our lives changed. That makes DVC less viable for us. We looked at renting points out but that involves cross border taxes that we don't want to deal with. We could, but just seemed a hassle.
We decided to list our contract and see what happened. We set a price we would not go below and listed. Took a couple months but accepted an offer on exactly what we wanted. We have a delayed closing so have one more last hoorah to WDW with our points and then the ownership transfers. Because of the drop in the dollar and rise in prices we made (as the dollar is right now) about 18k CDN before commissions and fees over and above what we originally paid.
So for us, we owned for 8 years, made trips that we would have never have dreamed of, and made a massive profit. DVC has been amazing to us. Now, had we not sold, we would have been perfectly happy keeping it and continuing to use it, but decided to take advantage of the current hot market and see what happened. We are lucky, that may not always exist.
We recommend DVC to anyone that asks. But when we recommend, we try to give full disclosure. Yes it is expensive, yes fees go up, yes costs to visit can be crazy. But in the end, we got great use out of it. Our 10 day, 2 BR Aulani trip was priced at over 12K US for our room. No way we would have paid that cash for one trip. DVC made it happen for us.
The dollar value of DVC may become stagnant. Resale prices may drop, direct prices may plummet. But, since we have owned, every year, there have been people that said 'this is the cap'. Yet prices continued to rise. People say direct isn't worth it but for every 'Direct isn't worth it' thread there seems to be a 'I'm tired of being a second class citizen' thread.
Everyone is different and wants different things. Take in all the good and bad and make the decision that is best for you and your family whether it is buy direct, buy resale, or not buy at all. I just wouldn't let one person talk you in or out of the decision.