It depends upon the make up of your party, and your normal dining habits as to whether or not the DDP is of value to you.
Yep. We have two adults and one child. On each visit, we eat a nice dinner each night, or have a character meal. If we weren't on DDP, we probably would not eat lunches...or would certainly not eat lunches each day. And we would normally not snack much.
So when I calculate DDP for our family and our dining habits, I completely
disregard the value of both the CS and snack credits. In other words, I only use the price of the character meals, or what we
really would order if we were paying cash (not appy, entree, and dessert at each TS meal). When I do that, I usually figure DDP saves us +/-$100 on a 4-5 night trip -- and the CS and snack credits (virtually all of which we use) are just gravy. If I added the value of the CS and snacks, we'd probably save $3-400 per trip.
One thing that is important to remember when computing value is that DDP includes ALL taxes, and an 18% gratuity on each TS meal.
Other benefits of DDP include having the price of dining fixed for the vacation, not ordering something you don't really want because what you
really want is too expensive, trying restaurants you otherwise wouldn't try, and the convenience of the plan.
Cons -- for me -- are that I don't think we would ever use DDP for a trip of a week or more. Especially with the recent menu standardization, we would just get really tired of eating Disney food eventually.
Some people say it's just too much food for them, but I have yet to see a CM hold a gun to someone's head and force them to eat. We just don't eat what we don't want.
Some people don't like the necessity of making ADRs each day -- especially theme park commandos.
To us, that character event or nice dinner is an integral part of a Disney vacation -- so we look forward to those meals. Needing to make ADRs also causes us to think about what we want to do for dining, and I'm sure that planning improves our dining as much as park planning improves that aspect of our trips. The planned meals are a big plus for us, but they're not for everyone.