It never ceases to amaze me the extremes you find on these boards (and in life). The people who think nothing of dropping $20K cash on a DVC contract or those that are mortgaged/in debt to the hilt and still taking $10K vacations every year. Then you have all the people in the middle, like me.
I think there is a big difference between doing what is financially 100% right and doing something that adds positive value to your life. Yes, the black and white answer is to have no debt.
But for many of us, that would mean I would not have (at this point) 7 YEARS of awesome memories with my kids at WDW. My kids won't be little for long.
DVC has been a big part of making us "commit" to vacations and family time. Because at home, life just gets in the way sometimes. It just happens.
If you have reasonable debt (mortgage, car payment, student loan), savings/retirement plan, and no problems making your monthly payments then I say go for it. Do your research and make sure it is right for you and your family's needs and by the contract that fits that. And enjoy living your life in actuality and not just living on paper through a financial portfolio. You can't take it with you