ArielRae is right. There are SO many choices and it depends on what YOU are interested in seeing/doing (and are willing to spend).
As you know, embarkation doesn't really begin until 12:30pm'ish so it's not like you need to be right next door.
If it's just a place to sleep, so that you don't miss the cruise . . . I might consider something closer to the airports (northern NJ for EWR, or Queens for LGA/JFK).
So much to see & do in NY/NY and even nearby (Brooklyn, Westchester, NewJersey).
May I suggest you all decide on a plan of what you want to do . . . a) day before, depending on you arrive; b) evening before; c) morning of cruise . . . and then pick a hotel/location that fits your plan?