I think how you're paying also makes a huge difference - if you can pay cash, I think college is still a good investment. If you're going to finish with 5-figure debt and pay decades of interest on it, maybe a different route would be more suitable.
I have one on each path - DS14 is interested in trade school or an apprenticeship through our community college, DD11 has a career goal that requires a degree. And a lot of people are flabbergasted that I'm not pushing DS to "set his sights higher", even though the trades he's interested in (machining primarily, or maybe welding) pay well and are experiencing/expecting shortages of qualified new hires.
If I was going to push one of them to reconsider it would be DD11, who wants to be a teacher - $100K+ in education (not counting eventually needing a masters or the ongoing continuing ed requirements) to earn $35K/year in a high stress job that is constantly caught in the middle of political tug-of-wars just doesn't sound like a great path to me!